Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Oct 29, 2025

Currently if no reviewer can be found, we just output a generic string, the real reason is just logged. I don't think that this should happen often, but if it does, we could refactor determine_assignee to return the error instead of just logging it.

Fixes: #1762
Fixes: #2217

@Kobzol Kobzol requested a review from Urgau October 29, 2025 19:56
Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I would like to hear from @jackh726 as well.

View changes since this review

@jackh726 jackh726 added this pull request to the merge queue Oct 29, 2025
Merged via the queue into rust-lang:master with commit d37bb39 Oct 29, 2025
3 checks passed
@Kobzol Kobzol deleted the reroll branch October 29, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add command that rerolls assignment based on PR contents ([assign.owners]) add "bors reroll"

3 participants